Fix Kafka native DLQ sending to source topic instead of DLQ topic#2569
Merged
jeremydmiller merged 1 commit intoJasperFx:mainfrom Apr 23, 2026
Merged
Fix Kafka native DLQ sending to source topic instead of DLQ topic#2569jeremydmiller merged 1 commit intoJasperFx:mainfrom
jeremydmiller merged 1 commit intoJasperFx:mainfrom
Conversation
InlineKafkaSender read envelope.TopicName unconditionally, which is set to the source topic on inbound messages. When a buffered listener failed and routed to the native DLQ, the sender produced the failed message back to the source topic instead of the configured DLQ topic — creating a requeue loop and leaving the DLQ empty. Add a fixedDestination flag to InlineKafkaSender that pins production to the sender's own topic, ignoring envelope.TopicName. KafkaTopic and KafkaTopicGroup now construct the DLQ sender with fixedDestination: true. Regular publisher senders keep the existing behavior so dynamic per- message topic routing (envelope.TopicName overrides) continues to work. Adds BufferedDeadLetterQueueTests regression coverage verifying that a failed message under BufferedInMemory lands on the DLQ topic, not the source topic. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced Apr 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InlineKafkaSender read envelope.TopicName unconditionally, which is set to the source topic on inbound messages. When a buffered listener failed and routed to the native DLQ, the sender produced the failed message back to the source topic instead of the configured DLQ topic — creating a requeue loop and leaving the DLQ empty.
Add a fixedDestination flag to InlineKafkaSender that pins production to the sender's own topic, ignoring envelope.TopicName. KafkaTopic and KafkaTopicGroup now construct the DLQ sender with fixedDestination: true. Regular publisher senders keep the existing behavior so dynamic per- message topic routing (envelope.TopicName overrides) continues to work.
Adds BufferedDeadLetterQueueTests regression coverage verifying that a failed message under BufferedInMemory lands on the DLQ topic, not the source topic.